The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Error			Dec 11, 2025 1:10am

3 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Dec 11, 2025 1:10am
rivet-inspector	Ignored	Preview		Dec 11, 2025 1:10am
rivet-site	Ignored	Preview		Dec 11, 2025 1:10am

• chore(engine): test actors runner kv #3625
• chore(engine): test actor alarms #3624
• feat(engine): actors lifecycle testing #3623 👈 (View in Graphite)
• chore: setup rivet-engine api tests #3540
• main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3623

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3623

commit: 2fc28aa

Pull Request Review: Rivet Actors Lifecycle Testing

Summary

This PR introduces a comprehensive Rust-based test runner infrastructure for deep actor lifecycle testing. It replaces the previous TypeScript-based test runner with a pure Rust implementation, enabling better control over actor behavior simulation and lifecycle scenarios.

Changes: 21 files, +2813/-1059 lines

✅ Strengths

1. Excellent Architecture

• Clean separation of concerns: actor.rs, behaviors.rs, protocol.rs, runner.rs
• Well-designed trait-based actor system with TestActor trait
• Flexible factory pattern for actor behaviors
• Good use of channels for event and KV request handling

2. Comprehensive Test Coverage

The new tests cover critical lifecycle scenarios: actor creation, start timeouts, crash policies, graceful shutdown, input verification, and state transitions.

3. Better Test Reliability

• Uses notification channels instead of arbitrary sleeps
• Proper polling with timeouts instead of fixed delays
• Clear actor behavior simulation via dedicated behavior structs

⚠️ Issues & Concerns

1. Critical: Debug Code in term_signal.rs:119

Debug log message "hello?" and commented-out code should be removed.

2. Empty File: actors_alarms.rs

Either remove this file or add a TODO comment explaining future plans.

3. Error Handling Concerns

• Silent failures in ActorConfig when sending events (actor.rs:85)
• Potential panics from mutex.expect() in behaviors.rs:75

4. Code Style Violations

From CLAUDE.md: Do not glob import from anyhow

Found in:

• behaviors.rs:2
• actor.rs:1
• protocol.rs:1
• runner.rs:2

Fix: Replace use anyhow::*; with use anyhow::{Result, Context, anyhow};

Also: Move inline import to top of file in runner.rs:184

5. Inconsistent Assertion (actors_lifecycle.rs:125)

Comment says "reschedule_ts is always Some(), not sure if this is intended" - needs clarification.

6. Potential Race Conditions

wait_ready() in runner.rs:240-247 has no timeout and could hang indefinitely.

7. Missing HTTP/WebSocket Implementation

Tests reference TODO comments about HTTP tunneling. Consider marking as #[ignore] or creating tracking issues.

🔒 Security

No major security issues found. The hardcoded token "dev" is fine for tests.

📋 Test Coverage

Well-Covered: Basic creation, input verification, timeouts, crash policies, shutdown

Missing: Actor alarms, HTTP/WebSocket tunneling, KV operations, error scenarios

📝 Recommendations

High Priority

1. Fix debug code in term_signal.rs
2. Fix anyhow glob imports in 4 files
3. Address reschedule_ts assertion clarity
4. Add timeouts to polling loops

Medium Priority

5. Improve error handling with logging
6. Remove or document actors_alarms.rs
7. Standardize test naming

✨ Overall Assessment

This is a high-quality PR that significantly improves the testing infrastructure.

Verdict: Approve with Minor Changes Required

Score: 8.5/10

• Architecture: 9/10
• Code Quality: 8/10
• Test Coverage: 9/10
• Documentation: 8/10

Great work! 🚀